[SUBMOD: a Political Overhaul] PIGS Alpha_02 (DeI 1.2.5) [upd: jun.09/19]

[Jake Armitage]

I've still to check how it works and how much it lags, maybe it will be included, maybe it will be optional

here it is (should be for both 4 and 12 tpy)
https://www.mediafire.com/file/7mj75...a_AI.pack/file

[nikossaiz]

thanks Jake! that was really fast! so for clariffication, this pack is for testudo ( both 4tpy and 12 tpy ). I used the one ivanpera posted with plain DEI and Scipios' realism for testing and
a) there is no extra lug at all.
b) seems quite stable, both AI and players' UI is ok, fx seems right
c) fx applied on same turn
d) is imersive as hell
e) only bug that occurs with both "original" PIGs and ivanperas. sometimes the generals who leeding navys have two different ui Pigs icon with different fx. age is the same. for example. Green possitive ui icon and next to it a red neggative one.

[Jake Armitage]

the pack I've uploaded is ivanpera's script as requested by leo.
so if you were using the file ivanpera uploaded (which is the entire PIGS) you don't need to use the patch.

this pack will overwrite the script
it is compatible both with testudo and pigs (you'll need one of the 2)
testudo already contains pigs, so you can just use the patch

abcd) good
e) I'll have to check, maybe ivanpera forgot an entry for admirals and so the previous effect is not going away

[ivanpera]

thanks Jake! that was really fast! so for clariffication, this pack is for testudo ( both 4tpy and 12 tpy ). I used the one ivanpera posted with plain DEI and Scipios' realism for testing and
a) there is no extra lug at all.
b) seems quite stable, both AI and players' UI is ok, fx seems right
c) fx applied on same turn
d) is imersive as hell
e) only bug that occurs with both "original" PIGs and ivanperas. sometimes the generals who leeding navys have two different ui Pigs icon with different fx. age is the same. for example. Green possitive ui icon and next to it a red neggative one.

Glad to hear it's working well. Just to be clear, are you saying that only admirals get a double trait? By chance, are these admirals leading a navy that's escorting an army?

[nikossaiz]

Glad to hear it's working well. Just to be clear, are you saying that only admirals get a double trait? By chance, are these admirals leading a navy that's escorting an army?

No, every time an admiral have a double trait is with his fleet alone. Ussually happens from the start of a campaign, and with the first .pack you uploaded + DEI , playing with seleucids and Macedon is always the admiral.

EDIT 1 ) BUT. it seem there is an inconcistancy according to who is going to get a double icon. I will see it again today, but i think among the player generals and admirals is always one that have a double icon. ( never saw AI general with this problem though ) Started a new campaign with seleucids "general attributes" ( the .pack Jake uploaded two posts before) and "testudo" everything seemed normal. Once i changed a general on an army with another, the new general had a double icon. i havent change another to see results, I must test it a little bit more to be honest, since i had my mind on the trait system by caramanus yesterday.

[ivanpera]

No, every time an admiral have a double trait is with his fleet alone. Ussually happens from the start of a campaign, and with the first .pack you uploaded + DEI , playing with seleucids and Macedon is always the admiral.

EDIT 1 ) BUT. it seem there is an inconcistancy according to who is going to get a double icon. I will see it again today, but i think among the player generals and admirals is always one that have a double icon. ( never saw AI general with this problem though ) Started a new campaign with seleucids "general attributes" ( the .pack Jake uploaded two posts before) and "testudo" everything seemed normal. Once i changed a general on an army with another, the new general had a double icon. i havent change another to see results, I must test it a little bit more to be honest, since i had my mind on the trait system by caramanus yesterday.

I'll give a quick look later.
Does the double effect appear in the same turn you replace a general/admiral or from the turn after?
If that's the case I might know what's wrong and how to (kinda) fix it

[nikossaiz]

Ok, i manage to track the bug and reproduce it. A) when you make a new army the general have attribute icon the next turn. Existed once have it from the start. If you replace a general or an admiral, the NEXT turn he will have double icon with attributes. If you replace him again the new one will three and so on.

[ivanpera]

Ok, i manage to track the bug and reproduce it. A) when you make a new army the general have attribute icon the next turn. Existed once have it from the start. If you replace a general or an admiral, the NEXT turn he will have double icon with attributes. If you replace him again the new one will three and so on.

I think I know why these two bugs occur.
The first *may* be harder to fix, but I think I know how to sort of fix the other one (if all goes well, when you will replace a commander the effect from the new one will appear only on the next turn).
I'll see when I get home

[Jake Armitage]

thanks for doing this ivan, I surely wouldn't be capable...

[ivanpera]

Niko, try this.
http://www.filedropper.com/pigscharivanperaaitestfix_2

It should work fine, but since I took a completely different approach (simpler and lighter) I don't know if there might be edge cases that break anything.
As I said, new effects will take place on the next turn, so an army won't have an effect the turn it's created and replacing a general won't update the army effect.
I'll try today to make another pack that handles those two situations, but if I don't succeed I think I'll leave this version as it is. Modding for this game is too time consuming for me as of now

[Jake Armitage]

thanks.
there is no real need to have it triggering the same turn, you can leave as it is, it won't change anything.

[nikossaiz]

Really Thank you Ivan! I will give it a try today! As jake said, doesn't matter if it triggers a turn after! And Fortunately this will be the definite solution, if jake confirm that is compatible! Thanks again!

[Jake Armitage]

if it works the pack is 100% compatible with pigs and testudo too.
load it before, obviously

[nikossaiz]

Perfect! Thanks!

[leonardusius]

Niko, try this.
http://www.filedropper.com/pigscharivanperaaitestfix_2
It should work fine, but since I took a completely different approach (simpler and lighter) I don't know if there might be edge cases that break anything.

And what's this, please ?

[Jake Armitage]

it should give the General's status (the effect with age, moral, mental, physical) to AI too without serious lags.

[nikossaiz]

Hello jake, have you test the newest ivanperas pigsai ? In an ongoing campaign it seems to instantly give 2 icons on my generals. This time age is the proper on both icons text, only the attributes are different ( witch are random anyway ) so I suppose that the pack works fine and the problem may be that testudo already includes PIGs ? On a new campaign everything (seems) fine so is not a real problem.

[Jake Armitage]

no, haven't tried and no it's not a problem of testudo/pigs, the overwriting is exactly the same.

try to do this: open a new campaign, end turn, save, load, end turn and see if the icons are 2.

[ivanpera]

Hello jake, have you test the newest ivanperas pigsai ? In an ongoing campaign it seems to instantly give 2 icons on my generals. This time age is the proper on both icons text, only the attributes are different ( witch are random anyway ) so I suppose that the pack works fine and the problem may be that testudo already includes PIGs ? On a new campaign everything (seems) fine so is not a real problem.

I forgot to say it's not compatible with the previous one. With the new pack, there are no more calls to delete old effects (which were assigned permanently and deleted by hand), so the one you previously had will stay there forever, alongside the new ones from the fix

[nikossaiz]

try to do this: open a new campaign, end turn, save, load, end turn and see if the icons are 2.

tryed and 1 icon only! so this is the definite solution!! Thanks again Jake!

@ Ivanpera

Thanks for the solution! i appreciate it!